-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backward for op desc #4573
Merged
JiayiFeng
merged 13 commits into
PaddlePaddle:develop
from
JiayiFeng:dev_backward_for_op_desc
Oct 7, 2017
Merged
Backward for op desc #4573
JiayiFeng
merged 13 commits into
PaddlePaddle:develop
from
JiayiFeng:dev_backward_for_op_desc
Oct 7, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev_backward_for_op_desc
… dev_backward_for_op_desc
… dev_backward_for_op_desc
… dev_backward_for_op_desc
…/reyoung/Paddle into dev_backward_for_op_desc_dev
… dev_backward_for_op_desc
wangkuiyi
approved these changes
Oct 7, 2017
@@ -270,5 +272,145 @@ std::unique_ptr<OperatorBase> Backward( | |||
return BackwardRecursive(forwardOp, no_grad_names, uid); | |||
} | |||
|
|||
// ==================================== // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid dismiss your approving, I will merge the pr first and remove it in the next pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #4566