Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support broadcast elementwise operators with int64 index type #45741

Merged
merged 16 commits into from
Sep 16, 2022

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 5, 2022

PR types

Bug fixes

PR changes

OPs

Describe

Support broadcast elementwise operators with int64 index type when the numel of the tensor is larger than INT32_MAX.

NOTE: This PR makes the PaddlePaddle wheel and libpaddle_inference.so increase about 70M. The reason is that the BroadcastKernel is a commonly used C++ template function, and it is instantiated many times (for different data types, different operators, etc). It is inevitable so far.

@paddle-bot
Copy link

paddle-bot bot commented Sep 5, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sneaxiy sneaxiy changed the title Support non-broadcast elementwise operators with int64 index type Support broadcast elementwise operators with int64 index type Sep 8, 2022
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 20b5bf8 into PaddlePaddle:develop Sep 16, 2022
@sneaxiy sneaxiy deleted the support_int64_non_broadcast branch September 16, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants