[AutoParallel] adapt lazyinit & fix pass #45840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Sep 7, 2022
| @@ -304,7 +338,10 @@ def main_program(self): | |||
|
|
|||
| @property | |||
| def startup_program(self): | |||
| return self.concrete_program.startup_program | |||
| try: | |||
| return self.proxy_layer.startup_program | |||
There was a problem hiding this comment.
因为用户有可能并没有用 LazyGuard，在这种情况下也需要保证正确执行之前无lazyinit版本的动转静。
| @@ -199,6 +206,7 @@ def __init__(self, layer, loss_func, metrics, inputs_spec, labels_spec): | |||
|
|
|||
| self.build_info = BuildInfo() | |||
| self._logger = get_logger(logging.INFO) | |||
| self.lazy_init = False | |||
There was a problem hiding this comment.
这个lazy_init参数的作用是什么？可否在这里Note注明下？
There was a problem hiding this comment.
这里是为了表示用户是否使用了 LazyGuard。如果没有的话（False），会直接利用 model 初始化时的参数；如果使用了（True），会通过执行 startup_program 来初始化参数
Aurelius84
reviewed
Sep 7, 2022
| } | ||
| # slice param_value with dist_attr | ||
| # share sliced_param_value with param_tensor in global_scope | ||
| from .converter import Converter |
There was a problem hiding this comment.
import 语句不要动态import，推荐统一放到最前面
JZ-LIANG
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
auto_parallel_gpt_model.pyto weight_sharing version in unittest