Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in "test_custom_plugin_creater" unit test #46075

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix bugs in "test_custom_plugin_creater" unit test #46075

merged 1 commit into from
Sep 16, 2022

Conversation

weishengying
Copy link
Contributor

@weishengying weishengying commented Sep 15, 2022

PR types

Bug fixes

PR changes

Others

Describe

修复 单元测试 test_custom_plugin_create的问题。 在 @JZZ-NOTE pr 合入之后, 注册 plugin 的方式发生了改变,从注册静态变量变成了注册方法。因此在 test_custom_plugin_create.cc代码内部,需要调用
tensorrt::plugin::TrtPluginRegistry::Global()->RegistToTrt();
才能看到注册的 plugin

Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉写单测有点麻烦了,现在这个注册默认在pass中,感觉以后可以在trt相关code里自动注册下

@jiweibo jiweibo merged commit be00a42 into PaddlePaddle:develop Sep 16, 2022
@weishengying weishengying deleted the bug-fix branch September 18, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants