Polish CompileTime InferShape #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. InferShape should be a method for `OpDescBind` not `Operator`, since `OpDescBind` is a compile-time concept. 2. Pre-create operators and store them into a map. Make InferShape faster
jacquesqiao
reviewed
Oct 10, 2017
paddle/framework/op_desc.cc
Outdated
| for (auto &pair : OperatorWithKernel::AllOpKernels()) { | ||
| auto &info = info_map.Get(pair.first); | ||
| auto op = | ||
| static_cast<OperatorWithKernel *>(info.Creator()("", {}, {}, {})); |
There was a problem hiding this comment.
can we directly use the creator with no input/output? we call https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/framework/operator.h#L139 to check if all the input/output is set.
There was a problem hiding this comment.
Since type is empty, the checks will be ignored.
… feature/polish_infer_shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpDescBindnotOperator, sinceOpDescBindis a compile-time concept.faster