Correct the logic and remove unnecessary template param #46623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
reviewed
Oct 8, 2022
| dim, | ||
| ignore_idx, | ||
| lbl); | ||
| if (lbl == ignore_idx) { |
There was a problem hiding this comment.
前面PADDLE_ENFORCE里面已经判断了lbl == ignore_idx，这个if还需要吗？
There was a problem hiding this comment.
需要的，前面只是判断当前的lbl是否满足边界限制，即满足[0, dim)和lbl == ignore_idx两者其一。后续计算还是需要根据lbl == ignore_idx与否走不同分支的
chenwhql
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
修复问题描述：
IgnoreIndex仅在ignore_index取值范围在[0, dim)时才生效，但是当某个label值超出了边界，ignore_index等于该label，这种情况下是应该仍然能正常计算。虽然当前的计算逻辑在结果上不会出错，但逻辑上仍是有问题的，且模板参数IgnoreIndex是没有必要的.assert在release模式下无法生效，且需要更全面的报错信息，因此将assert改为PADDLE_ENFORCE