Fix set_value failure when source tensor is fp16 Dtype #46801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
qingqing01
approved these changes
Oct 10, 2022
Shixiaowei02
approved these changes
Oct 10, 2022
Xreki
approved these changes
Oct 11, 2022
| @@ -724,6 +724,19 @@ KernelSignature SetValueOpArgumentMapping(const ArgumentMappingContext& ctx) { | |||
| "shape", | |||
| "bool_values"}, | |||
| {"Out"}); | |||
| } else if (ctx.HasAttr("fp16_values")) { | |||
| // NOTE(LiuYang):Here any_cast doesn't support fp16 values. | |||
There was a problem hiding this comment.
fp16_values是用std::vector<float>存的，所以这里应该是any_cast<std::vector<float>>？
lanxianghit
pushed a commit
that referenced
this pull request
Oct 13, 2022
Fix set_value failure when source tensor is fp16 Dtype and destiny value is a number (dev PR link:#46801)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix set_value failure when source tensor is fp16 Dtype and destiny value is a number