Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bias caching and scales computation optimization for oneDNN FC #47234

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Oct 20, 2022

PR types

Performance optimization

PR changes

OPs

Describe

Fix for bias caching and scales computation optimization for oneDNN FC. Previously bias was not properly stored in cache and computing output scales was creating an unnecessary vector.

@paddle-bot
Copy link

paddle-bot bot commented Oct 20, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Oct 20, 2022
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 20, 2022
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor

jczaja commented Oct 24, 2022

@piotrekobi Please review

Copy link
Contributor

@piotrekobi piotrekobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants