Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demostrate fully connected layer without any helper #4724

Closed
wants to merge 3 commits into from

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 11, 2017

No description provided.


if not isinstance(param_attr, list) and not isinstance(param_attr, tuple):
raise TypeError(
"param attribute of fc should be a dict, or a sequence of dict")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if param_attr is a list of non-dict type, it will also pass all the above checks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}
}

if bias_attr:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems bias_attr will never be None here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. bias_attr is False by default. If bias_attr is False, there is no bias. If bias_attr is None or True, a default bias attr will be set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@reyoung reyoung closed this Oct 17, 2017
@reyoung reyoung deleted the feature/fc_layer branch October 28, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants