Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick Release/2.4] Fix multi_tensor adam and momentum bug when the parameter is list of dict #47372

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Oct 26, 2022

PR types

Bug fixes

PR changes

APIs

Describe

Cherry-pick #47352 .

Note: since the black formatting tools have been added recently, lots of the changes in this PR is from the black formatting. For better review, I separate 2 commits in this PR: the 1st commit contains only the changes from black formatting, and the 2nd commit contains only the changes from the cherry-picked PR #47352.

@sneaxiy sneaxiy closed this Oct 26, 2022
@sneaxiy sneaxiy reopened this Oct 26, 2022
@sneaxiy sneaxiy changed the title [Cherry-pick][Release/2.4] Fix multi_tensor adam/momentum bug when the parameter is list of dict [Cherry-pick][Release/2.4] Fix multi_tensor adam and momentum bug when the parameter is list of dict Oct 26, 2022
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 26, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 26, 2022
@sneaxiy sneaxiy closed this Oct 26, 2022
@sneaxiy sneaxiy reopened this Oct 26, 2022
@sneaxiy sneaxiy changed the title [Cherry-pick][Release/2.4] Fix multi_tensor adam and momentum bug when the parameter is list of dict [Cherry-pick Release/2.4] Fix multi_tensor adam and momentum bug when the parameter is list of dict Oct 26, 2022
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 94240e2 into PaddlePaddle:release/2.4 Oct 27, 2022
@sneaxiy sneaxiy deleted the fix_multi_tensor_adam_and_momentum_2.4 branch October 27, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants