Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[with_data_parallel][part2] remove with_data_parallel in unit test #50501

Merged

Conversation

kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Feb 14, 2023

PR types

Others

PR changes

APIs

Describe

remove with_data_parallel in unit test

1. Why delete these unit case?

The ParallelExecutor will be removed in the later of this year and are not maintained right now. In this stage, we just delete the unit cases that are related to multi-gpus.

2. What else does this PR do?

  1. The unit tests that contains with_data_parallel but are not about ParallelExecutor should leave it as it is except removing with_data_parallel.
  2. add assert in with_data_parallel to prevent new multi-gpu case before deleting api.

Related PRs

  1. [with_data_parallel][part1] remove with_data_parallel in unit test #50351

@paddle-bot
Copy link

paddle-bot bot commented Feb 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli merged commit 7a156f1 into PaddlePaddle:develop Feb 21, 2023
@kangguangli kangguangli deleted the remove_with_data_parallel_unittest branch March 1, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants