Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zero-Dim] support input 0D for gcd and lcm #50950

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Feb 27, 2023

PR types

New features

PR changes

APIs

Describe

add zero-dim unit test for gcd and lcm

@paddle-bot
Copy link

paddle-bot bot commented Feb 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title zero-dim support for gcd and lcm [Zero-Dim] support input 0D for gcd and lcm Feb 27, 2023
@@ -282,6 +282,8 @@ def test_static_reduce(self):
paddle.bitwise_and,
paddle.bitwise_or,
paddle.bitwise_xor,
paddle.gcd,
Copy link
Contributor

@zhwesky2010 zhwesky2010 Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个API有没有反向,目前binary_int_api_list没写反向测试

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对比Pytorch、Numpy、Tensorflow三者的实现,这两个API都没有反向实现。

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit c77eb1f into PaddlePaddle:develop Feb 28, 2023
@luotao1 luotao1 deleted the zero_dim_gcd_lcm branch June 26, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants