Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewIR]Disable copy and assign for Operation #55328

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

Aurelius84
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Pcard-67164
[NewIR]Disable copy and assign for Operation

@paddle-bot
Copy link

paddle-bot bot commented Jul 11, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IR属于置于Phi的下层。非必要不建议在ir.core里面引入phi的头文件。

@Aurelius84
Copy link
Contributor Author

IR属于置于Phi的下层。非必要不建议在ir.core里面引入phi的头文件。

赞同。我在ir/core下新增了一个 macros.h 来定义 DISABLE_COPY_AND_ASSIGN

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 4c5ce83 into PaddlePaddle:develop Jul 13, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* [NewIR]Disable copy and assign for Operation

* add macros.h
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
* [NewIR]Disable copy and assign for Operation

* add macros.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants