Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【inplace api】batch add inplace api paddle.log_, paddle.i0_, paddle.nn.functional.leaky_relu_... #55576

Merged
merged 10 commits into from
Jul 27, 2023

Conversation

GGBond8488
Copy link
Contributor

@GGBond8488 GGBond8488 commented Jul 20, 2023

PR types

Others

PR changes

APIs

Description

Pcard-72375
batch add inplace api as follow

paddle.nn.functional.hardtanh_
paddle.nn.functional.leaky_relu_
paddle.nn.functional. thresholded_relu_
paddle.digamma_
paddle.trunc_
paddle.frac_
paddle.i0_
paddle.lgamma_
paddle.log_
paddle.log10_
paddle.log1p_
paddle.log2_
paddle.logit_
paddle.neg_
paddle.polygamma_
paddle.tril_
paddle.triu_
paddle.trunc_

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhangrui34 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot
Copy link

paddle-bot bot commented Jul 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@GGBond8488 GGBond8488 force-pushed the batch_add_inpalce_api_3 branch 2 times, most recently from cd1f1f2 to 5723cb2 Compare July 24, 2023 08:57
@GGBond8488 GGBond8488 closed this Jul 24, 2023
@GGBond8488 GGBond8488 reopened this Jul 24, 2023
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,这个先合,后续还需要做:

  • api_label 完善,是paddle.nn.functional下的inpalce文档能正确引用
  • 提供inplace api对应的中文文档

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional目录下的inpalce版api文档,都没有引用成功。后续请补一下api_label

@jeff41404
Copy link
Contributor

jeff41404 commented Jul 27, 2023

we need to describe in PR title which inplace APIs will be add, it is better to use [add inplace API] paddle.log_/log2_, ...

@GGBond8488 GGBond8488 changed the title batch add inplace api 【inplace api】batch add inplace api Jul 27, 2023
@GGBond8488 GGBond8488 changed the title 【inplace api】batch add inplace api 【inplace api】batch add inplace api paddle.log_, paddle.i0_, paddle.nn.functional.leaky_relu_... Jul 27, 2023
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 58a03d4 into PaddlePaddle:develop Jul 27, 2023
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
….functional.leaky_relu_... (PaddlePaddle#55576)

* batch add inplace api

* add inplace test

* add activation inplace

* fix test

* remove atan2 ge, gt, le, lt, nq

* remove atan2 ge, gt, le, lt, nq

* fix windows ci error

* rerun ci

* fix typro

* fix bugs

---------

Co-authored-by: zhangrui34 <v_zhangrui34@baidu.com>
jinjidejinmuyan pushed a commit to jinjidejinmuyan/Paddle that referenced this pull request Aug 30, 2023
….functional.leaky_relu_... (PaddlePaddle#55576)

* batch add inplace api

* add inplace test

* add activation inplace

* fix test

* remove atan2 ge, gt, le, lt, nq

* remove atan2 ge, gt, le, lt, nq

* fix windows ci error

* rerun ci

* fix typro

* fix bugs

---------

Co-authored-by: zhangrui34 <v_zhangrui34@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants