-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify compare logical inplace #56888
Merged
jeff41404
merged 11 commits into
PaddlePaddle:develop
from
GGBond8488:modify_compare_logical_inplace
Sep 13, 2023
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ba9a9cf
fix error
GGBond8488 bc2362f
fix compare
GGBond8488 7567bbf
fix
GGBond8488 a52affa
fix
GGBond8488 350aa2a
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
GGBond8488 92b4d06
remove fluid
GGBond8488 3dac08d
Merge branch 'develop' into modify_compare_logical_inplace
GGBond8488 d20f51b
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
GGBond8488 ffea7a0
fix inpalce test
GGBond8488 8537e6b
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
GGBond8488 3388e74
fix and sep inpalce impl
GGBond8488 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why create
InplaceLogicalKnernelImpl
here while not create inlogical_kernel.cc
, can we integrate code ofLogicalKnernelImpl
andInplaceLogicalKnernelImpl
intoLogical##type##Kernel
to maintain the same form aslogical_kernel.cc