Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Unify dyn_cast interface with pir::cast #57463

Merged
merged 11 commits into from
Sep 27, 2023

Conversation

zhangbopd
Copy link
Contributor

@zhangbopd zhangbopd commented Sep 18, 2023

PR types

Others

PR changes

Others

Description

  • 规范接口中的命名方式
  • 统一接口中 dyn_cast 的风格和命名

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 18, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangbopd zhangbopd changed the title [pir] Unify dyn_cast interface with pir::cast [PIR] Unify dyn_cast interface with pir::cast Sep 18, 2023
@@ -37,6 +37,14 @@ class InferMetaInterface : public pir::OpInterfaceBase<InferMetaInterface> {
};

/// Constructor
InferMetaInterface(std::nullptr_t) // NOLINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个构造函数的增加感觉不是必要的,而且会给IR库的扩展着造成额外的负担。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,这里是想把 interface 抽出来,做一个 interfaceBase 的,在没有做 interfaceBase 前先和 op 的保持一致

@PaddlePaddle PaddlePaddle deleted a comment from winter-wang Sep 18, 2023
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface新增的两个构造函数不是必须的。会给Interface的开发者造成额外的负担,不建议增加。

@PaddlePaddle PaddlePaddle deleted a comment from paddle-ci-bot bot Sep 26, 2023
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbopd zhangbopd merged commit de9818f into PaddlePaddle:develop Sep 27, 2023
27 checks passed
@zhangbopd zhangbopd deleted the dyn_cast_interface branch September 27, 2023 02:43
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* PR comment

* unify dyn_cast_interface

* rm detail
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* PR comment

* unify dyn_cast_interface

* rm detail
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* PR comment

* unify dyn_cast_interface

* rm detail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants