Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.25】add gammaln api -part #59311

Merged
merged 15 commits into from
Dec 28, 2023
Merged

【Hackathon 5th No.25】add gammaln api -part #59311

merged 15 commits into from
Dec 28, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 23, 2023

PR types

New features

PR changes

APIs

Description

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 23, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 23, 2023
@luotao1 luotao1 mentioned this pull request Nov 24, 2023
Open
@GreatV GreatV mentioned this pull request Nov 24, 2023
Closed
26 tasks
@YibinLiu666 YibinLiu666 mentioned this pull request Nov 24, 2023
Merged
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 30, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 30, 2023
@luotao1
Copy link
Contributor

luotao1 commented Dec 1, 2023 

2023-11-30 16:41:34 The following tests FAILED:
2023-11-30 16:41:34 	1698 - test_gammaln_op (Timeout)

@xuxinyi389
Copy link
Contributor

通过下覆盖率测试@GreatV

@luotao1
Copy link
Contributor

luotao1 commented Dec 19, 2023

image

可能HOSTDEVICE代码覆盖不到

@GreatV
Copy link
Contributor Author

GreatV commented Dec 19, 2023

image 可能HOSTDEVICE代码覆盖不到

不知道咋处理

@xuxinyi389
Copy link
Contributor

xuxinyi389 commented Dec 19, 2023 •
edited
Loading

image 可能HOSTDEVICE代码覆盖不到

不知道咋处理

coverage流水线可能存在问题，你可以仿照#58092 这个同学的处理方式，通过log的方式说明覆盖了这些代码，然后申请豁免

@GreatV
Copy link
Contributor Author

GreatV commented Dec 19, 2023

加了一个日志，本地运行测试，确实是经过了这个函数。
image

image

@GreatV
Copy link
Contributor Author

GreatV commented Dec 20, 2023

中文文档

sunzhongkai588
sunzhongkai588 previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuxinyi389
Copy link
Contributor

这个使用了Eigen，rfc中还需调研清楚pytorch在GPU是如何实现的。偷懒的做法要改掉，不能依赖Eigen。
Eigen的问题可以参考上次黑客松这个PR的讨论
#52058 @GreatV

@GreatV
Copy link
Contributor Author

GreatV commented Dec 20, 2023

这里用的是numext命名空间的函数是scalar版的，应该不影响高维tensor。 @xuxinyi389

@xuxinyi389
Copy link
Contributor

这里用的是numext命名空间的函数是scalar版的，应该不影响高维tensor。 @xuxinyi389

好的，我再确认下。RFC中pytorch的GPU具体实现麻烦你再补充下。

@GreatV
Copy link
Contributor Author

GreatV commented Dec 21, 2023

好的，我再确认下。RFC中pytorch的GPU具体实现麻烦你再补充下。

好的，稍后补充。

@xuxinyi389
Copy link
Contributor

好的，我再确认下。RFC中pytorch的GPU具体实现麻烦你再补充下。

好的，稍后补充。

确认了下，明确不能使用eigen库，可以调研下pytorch的GPU实现然后再修改下

@GreatV
Copy link
Contributor Author

GreatV commented Dec 22, 2023 •
edited
Loading

确认了下，明确不能使用eigen库，可以调研下pytorch的GPU实现然后再修改下

好的

@xuxinyi389
Copy link
Contributor

xuxinyi389 commented Dec 22, 2023 •
edited
Loading

LGTM + 需要实现移除eigen库依赖，补充RFC，完善API文档，

@xuxinyi389
Copy link
Contributor

LGTM + （pytorch的GPU实现情况同步到RFC，具体实现有相应变化也同步到RFC和API文档中）

@GreatV GreatV mentioned this pull request Dec 26, 2023
Merged
@GreatV
Copy link
Contributor Author

GreatV commented Dec 26, 2023

RFC 已更新

@xuxinyi389
Copy link
Contributor

LGTM

jeff41404
jeff41404 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit beba862 into PaddlePaddle:develop Dec 28, 2023
29 checks passed
@luotao1 luotao1 changed the title 【Hackathon 5th No.25】add gammaln api 【Hackathon 5th No.25】add gammaln api -part Dec 28, 2023
xuxinyi389 added a commit to xuxinyi389/Paddle that referenced this pull request Dec 28, 2023
@xuxinyi389
Revert "【Hackathon 5th No.25】add gammaln api (PaddlePaddle#59311)"
e99a4ad 
This reverts commit beba862.
@xuxinyi389 xuxinyi389 mentioned this pull request Dec 28, 2023
Merged
cxxly pushed a commit that referenced this pull request Dec 28, 2023
@xuxinyi389
Revert "【Hackathon 5th No.25】add gammaln api (#59311)" (#60450)
d72ed8a 
This reverts commit beba862.
@GreatV GreatV mentioned this pull request Jan 2, 2024
Merged
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
@GreatV
【Hackathon 5th No.25】add gammaln api (PaddlePaddle#59311)
0757f38
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
@xuxinyi389
Revert "【Hackathon 5th No.25】add gammaln api (PaddlePaddle#59311)" (P…
fd15e32 
…addlePaddle#60450)

This reverts commit beba862.
@jeff41404 jeff41404 mentioned this pull request Jan 8, 2024
Merged
@GreatV GreatV deleted the add_gammaln_op branch February 7, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuxinyi389 xuxinyi389 xuxinyi389 left review comments

@jeff41404 jeff41404 jeff41404 approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 left review comments

Assignees

@luotao1 luotao1

@jeff41404 jeff41404

@sunzhongkai588 sunzhongkai588

@xuxinyi389 xuxinyi389

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GreatV @luotao1 @xuxinyi389 @jeff41404 @sunzhongkai588