Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] add _check_dist_attr #60336

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

AndSonder
Copy link
Contributor

PR types

Others

PR changes

Others

Description

VPP引入之前 Reshard 之后一般就需要看分布式视角了,比如 Reshard 之后的一些 pass 都是没有从分布式的视角去做
但是VPP场景下Reshard之后还有可能去编排,因此加上 _check_dist_attr 强制要求以后的 pass 都要初始化 dist

Copy link

paddle-bot bot commented Dec 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 25, 2023
@AndSonder
Copy link
Contributor Author

AndSonder commented Jan 3, 2024

目前有如下 pass 需要进行修复:

Copy link

paddle-ci-bot bot commented Jan 11, 2024

Sorry to inform you that a61ff89's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 90c1996 into PaddlePaddle:develop Jan 24, 2024
29 checks passed
eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Jan 30, 2024
* add _check_dist_attr

* fix

* rewrite _check_dist_attr

* change _check_dist_attr position

* add use_new_executor() condition for _check_dist_attr

* add dist attr for fill_constant op
@AndSonder AndSonder deleted the check_dist_attr branch April 23, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants