Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2_API equation for img_pool and maxout format. #6392

Merged

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Dec 7, 2017

fix #6393
Currently, the format of equation for img_pool and maxout is very messy.
paddle.v2.layer.img_pool
paddle.v2.layer.maxout

@luotao1
Copy link
Contributor

luotao1 commented Dec 7, 2017

Please paste the current format of the equation, thanks!

@chengduoZH
Copy link
Contributor Author

wx20171207-221959 2x

@@ -2722,14 +2722,14 @@ def img_pool_layer(input,

.. math::

w = 1 + int(ceil(input\_width + 2 * padding - pool\_size) / float(stride))
w = 1 + int(ceil(input\_width + 2 * padding - pool\_size) / float(stride)) \\\\
h = 1 + int(ceil(input\_height + 2 * padding\_y - pool\_size\_y) / float(stride\_y))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

作为公式的话,int, float是不是去掉,ceil换成对应的取整符号,/变成上下除的格式,显示时会更好看点。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit b6e67f6 into PaddlePaddle:develop Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix API equation for img_pool and maxout format
2 participants