Refine conv #6455
Merged
Refine conv #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
refine/conv_zero
branch
from
9e80a00
to
aa2f2fb
Compare
qingqing01
previously approved these changes
Dec 14, 2017
paddle/operators/conv_transpose_op.h
Outdated
| @@ -225,7 +225,7 @@ class GemmConvTransposeGradKernel : public framework::OpKernel<T> { | |||
|
|
|||
| if (input_grad) { | |||
| input_grad->mutable_data<T>(context.GetPlace()); | |||
| set_zero(dev_ctx, input_grad, static_cast<T>(0)); | |||
| // set_zero is unnecessary, math::matmul will reset input_grad. | |||
There was a problem hiding this comment.
remove this comments in next PR.
There was a problem hiding this comment.
I can change it in this PR.
qingqing01
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6603