Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Infer Symbolic Shape No.123】【BUAA】Add Bincount #67435

Merged
merged 21 commits into from
Aug 23, 2024
Merged

【Infer Symbolic Shape No.123】【BUAA】Add Bincount #67435

merged 21 commits into from
Aug 23, 2024

Conversation

Whsjrczr
Copy link
Contributor

PR Category

CINN

PR Types

Others

Description

修改了3个文件，增加了BincountOpInferSymbolicShape

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 14, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 labels Aug 14, 2024
@Whsjrczr
Copy link
Contributor Author

引入新符号，请求豁免

gongshaotian
gongshaotian reviewed Aug 21, 2024
View reviewed changes
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc Outdated
symbol::DimExpr out_unknown =
infer_context->GetNextSymName(); // unknown until runtime

// Set the output shape, which is of unknown size (-1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉这个注释

@gongshaotian
Copy link
Contributor

需要在test/legacy_test/test_bincount_op.py 中关掉 check_symbol_infer flag。
image

@Whsjrczr Whsjrczr mentioned this pull request Aug 23, 2024
Merged
@luotao1 luotao1 closed this Aug 23, 2024
@luotao1 luotao1 reopened this Aug 23, 2024
@luotao1 luotao1 merged commit a5a32e4 into PaddlePaddle:develop Aug 23, 2024
28 checks passed
@Whsjrczr Whsjrczr mentioned this pull request Aug 26, 2024
Closed
35 tasks
This was referenced Sep 5, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongshaotian gongshaotian gongshaotian left review comments

@Hongqing-work Hongqing-work Hongqing-work approved these changes

Assignees

@luotao1 luotao1

@gongshaotian gongshaotian

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Whsjrczr