Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Infer Symbolic Shape No.92】【BUAA】 Add nll_loss op #67884

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

MufanColin
Copy link
Contributor

PR Category

CINN

PR Types

Improvements

Description

添加 nll_loss 算子符号推导接口。

Copy link

paddle-bot bot commented Aug 31, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 31, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Sep 2, 2024
PADDLE_ENFORCE_EQ(
x_shape[0],
label_shape[0],
phi::errors::InvalidArgument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该用euqalcstr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改。

true,
phi::errors::InvalidArgument("Input(X) tensor shape should "
"match to Input(Label) tensor "
"shape."));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该用equalcstr;这六个变量不用取出来,省去一次拷贝

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改。

Copy link
Contributor

@gongshaotian gongshaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MufanColin
Copy link
Contributor Author

Codestyle-Check 测试无权限重新运行。

@MufanColin
Copy link
Contributor Author

剩余的几个测试已经跑了好几天了,请问应该如何处理?

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 5, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 5, 2024
@gongshaotian
Copy link
Contributor

剩余的几个测试已经跑了好几天了,请问应该如何处理?

目前挂掉是coverage流水线的问题,rerun了

@MufanColin
Copy link
Contributor Author

好像还是没有过

@luotao1 luotao1 merged commit 9aacea9 into PaddlePaddle:develop Sep 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants