【Infer Symbolic Shape No.47】【BUAA】 Add frame op #67886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Sep 2, 2024
|
|
||
| std::vector<symbol::DimExpr> output_shape; | ||
| symbol::DimExpr n_frames; | ||
| symbol::DimExpr frame_length; |
There was a problem hiding this comment.
frame_length 应该需要从attribute里面取吧
gongshaotian
reviewed
Sep 2, 2024
| end_axis = x_rank - 2; | ||
| } | ||
|
|
||
| PADDLE_ENFORCE_LE(static_cast<int>(frame_length.Get<std::int64_t>()), |
There was a problem hiding this comment.
这个enforce缺少一个前置判断，判断x_shape中的DimExpr是不是全都是int类型
gongshaotian
reviewed
Sep 2, 2024
| "Attribute(frame_length) of FrameOp should be less " | ||
| "equal than sequence length, but got (%s) > (%s).", | ||
| static_cast<int>(frame_length.Get<std::int64_t>()), | ||
| static_cast<int>(seq_length.Get<std::int64_t>()))); |
There was a problem hiding this comment.
frame_length这里不需要cast了，是int类型的attribute
gongshaotian
reviewed
Sep 2, 2024
| output_shape.push_back(x_shape[i]); | ||
| } | ||
|
|
||
| if (seq_length == -1) { |
There was a problem hiding this comment.
这里应该是 !seq_length.isa<int64_t>()，再理解一下meta和符号推导是怎么表示动态维度的
gongshaotian
reviewed
Sep 2, 2024
| } | ||
|
|
||
| if (seq_length == -1) { | ||
| n_frames = -1; |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
添加 frame 算子符号推导接口。