Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error. #7605

Closed
wants to merge 1 commit into from
Closed

Conversation

gongweibao
Copy link
Contributor

@gongweibao gongweibao commented Jan 17, 2018

Fix #7632

Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an issue describing this PR.

The change looks to me like to remove a compilation warning of the lacking of a return statement in a function with non-void return type. I don't understnad why it's called a GRPC bug -- this PR is changing our code, not the GRPC code.

@gongweibao gongweibao changed the title Fix grpc bugs. Fix compilation warning. Jan 18, 2018
@gongweibao
Copy link
Contributor Author

@wangkuiyi You're right, this is my fault

@gongweibao gongweibao changed the title Fix compilation warning. Fix compilation error. Jan 18, 2018
@gongweibao
Copy link
Contributor Author

gongweibao commented Jan 19, 2018

Close it since the bug has been fixed.

@gongweibao gongweibao closed this Jan 19, 2018
@gongweibao gongweibao deleted the fixgrpc2 branch January 17, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants