fix assign value op bug #1350
Merged
fix assign value op bug #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix_assign_value_op_bug
risemeup1
force-pushed
the
fix_assign_value_op_bug
branch
from
c26572e
to
714585a
Compare
Jiang-Jia-Jun
approved these changes
Aug 15, 2024
SigureMo
approved these changes
Aug 15, 2024
| void GetScalars(const std::string &name, std::vector<double> *val){ | ||
| auto &op = parser_->GetOpDesc(block_idx_, op_idx_); | ||
| parser_->GetOpScalars<double>(op, name, val); | ||
| } |
There was a problem hiding this comment.
GetAttr 和 GetScalars 感觉都可以用模板简化～
paddle2onnx/parser/parser.h
Outdated
| @@ -187,6 +189,11 @@ class PaddleParser { | |||
| const std::string& tensor_name, | |||
| std::vector<T>* data) const; | |||
|
|
|||
| template <typename T> | |||
| void GetOpScalars(const paddle2onnx::framework::proto::OpDesc& op, | |||
There was a problem hiding this comment.
Suggested change
| void GetOpScalars(const paddle2onnx::framework::proto::OpDesc& op, | |
| void GetOpScalarsAttr(const paddle2onnx::framework::proto::OpDesc& op, |
感觉加上这个后缀表意能更明确些
Aurelius84
reviewed
Aug 15, 2024
| int32_t dtype = static_cast<int32_t>(dtype_); | ||
| std::string attr_name = HasAttr("values") ? "values" : GetAttrNameByDtype(dtype); |
There was a problem hiding this comment.
Suggested change
| std::string attr_name = HasAttr("values") ? "values" : GetAttrNameByDtype(dtype); | |
| const std::string attr_name = HasAttr("values") ? "values" : GetAttrNameByDtype(dtype); |
| if (handler != type_handlers.end()) { | ||
| handler->second(); | ||
| } else { | ||
| throw std::invalid_argument("Unsupported dtype value"); |
There was a problem hiding this comment.
可以看下2ONNX里面的异常抛出体系有没有统一的规范？
SigureMo
approved these changes
Aug 15, 2024
Jiang-Jia-Jun
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 assign_value中无法找到fp32_values属性的问题