[Bug fixes] update attribute map handler #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## develop #4421 +/- ##
===========================================
- Coverage 39.65% 39.62% -0.03%
===========================================
Files 433 433
Lines 60936 60983 +47
===========================================
+ Hits 24163 24167 +4
- Misses 36773 36816 +43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wj-Mcat
commented
Jan 11, 2023
Comment on lines
-732
to
-741
| # do standard config map: there are some old-school pretrained-config not refactored. | ||
| config_dict = convert_to_legacy_config(cls.attribute_map, config_dict) | ||
|
|
||
| config_dict = flatten_model_config(config_dict) | ||
| if "model_type" in config_dict and hasattr(cls, "model_type") and config_dict["model_type"] != cls.model_type: | ||
| logger.warning( | ||
| f"You are using a model of type {config_dict['model_type']} to instantiate a model of type " | ||
| f"{cls.model_type}. This is not supported for all configurations of models and can yield errors." | ||
| ) | ||
|
|
There was a problem hiding this comment.
将 convert_to_legacy_config和flatten_model_config迁移到from_dict函数中，因为：from_dict是from_pretrained的调用函数。
wj-Mcat
commented
Jan 11, 2023
Comment on lines
+201
to
+203
| value = config.pop(standard_field, None) or config.pop(paddle_field, None) | ||
| if value is not None: | ||
| config[paddle_field] = value |
There was a problem hiding this comment.
问题
问题是出在：将 attribute_map中的values 参数都映射到第一层级参数上，且都是：target_paddle_field: None。故导致init_args下的参数没办法正确 map 上来，比如d_model
为什么这样调整
- 老版本
model_config.json
{
"init_args": [
{
"tie_word_embeddings": false,
"pad_token_id": 0,
"bos_token_id": 0,
"eos_token_id": 1,
"vocab_size": 32128,
"d_model": 768,
"d_kv": 64,
"d_ff": 2048,
"num_layers": 12,
"num_decoder_layers": 12,
"num_heads": 12,
"relative_attention_num_buckets": 32,
"dropout_rate": 0.1,
"layer_norm_epsilon": 1e-06,
"initializer_factor": 1.0,
"feed_forward_proj": "gated-gelu",
"init_class": "T5Model"
}
],
"init_class": "T5ForConditionalGeneration"
}在老板本配置文件中，模型的参数是放在init_args参数中，而这个模块是先递归调用convert_to_legacy_config函数（深度优先），针对于模型参数做 map，此时可能会将hidden_size -> d_model。
可是执行完毕之后，老代码会在根目录上设置：d_model: None，导致flatten_model_config 中没办法将init_args中的正确d_model映射回来。
现在这种做法是可以解决这个问题。
- 在新版本的配置文件
config.json中
{
"architectures": [
"T5ForConditionalGeneration"
],
"bos_token_id": 0,
"d_ff": 2048,
"d_kv": 64,
"d_model": 768,
"dropout_rate": 0.1,
"enable_recompute": false,
"eos_token_id": 1,
"feed_forward_proj": "gated-gelu",
"initializer_factor": 1.0,
"is_encoder_decoder": true,
"layer_norm_epsilon": 1e-06,
"model_type": "t5",
"num_decoder_layers": 12,
"num_heads": 12,
"num_layers": 12,
"pad_token_id": 0,
"paddlenlp_version": null,
"relative_attention_max_distance": 128,
"relative_attention_num_buckets": 32,
"tie_word_embeddings": false,
"use_cache": true,
"vocab_size": 32128
}因为没有init_args参数，也是可以针对于模型参数做 map。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Description
update
attribute mappinginconfiguration_utilsmodule.try to fix: #4384