Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable isort after upstream bug is addressed #4577

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented Jan 30, 2023

PR types

PR changes

Description

Reference: PyCQA/isort#2083

@sijunhe sijunhe requested a review from wj-Mcat January 30, 2023 11:33
@paddle-bot
Copy link

paddle-bot bot commented Jan 30, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #4577 (d5cdfd7) into develop (6a0c50c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #4577   +/-   ##
========================================
  Coverage    41.31%   41.32%           
========================================
  Files          433      433           
  Lines        61820    61826    +6     
========================================
+ Hits         25540    25548    +8     
+ Misses       36280    36278    -2     
Impacted Files Coverage Δ
paddlenlp/transformers/bert/modeling.py 90.28% <100.00%> (+0.05%) ⬆️
paddlenlp/transformers/gpt/modeling.py 78.60% <100.00%> (+0.17%) ⬆️
paddlenlp/utils/downloader.py 59.01% <0.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sijunhe sijunhe merged commit e3484a0 into PaddlePaddle:develop Jan 30, 2023
@sijunhe sijunhe deleted the enable_isort branch January 30, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants