Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update llm docs requirements #8336

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Update llm docs requirements #8336

merged 3 commits into from
Apr 30, 2024

Conversation

w5688414
Copy link
Contributor

@w5688414 w5688414 commented Apr 26, 2024 •
edited
Loading

@w5688414 w5688414 requested a review from ZHUI April 26, 2024 09:44
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 26, 2024

Thanks for your contribution!

@w5688414 w5688414 mentioned this pull request Apr 26, 2024
Closed
@w5688414 w5688414 self-assigned this Apr 26, 2024
@w5688414 w5688414 mentioned this pull request Apr 29, 2024
Closed
@w5688414 w5688414 changed the title Update llm docs Update llm docs requirements Apr 29, 2024
ZHUI
ZHUI previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.37%. Comparing base (a37f53d) to head (0a75ceb).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8336      +/-   ##
===========================================
- Coverage    55.37%   55.37%   -0.01%     
===========================================
  Files          613      614       +1     
  Lines        95870    96013     +143     
===========================================
+ Hits         53084    53163      +79     
- Misses       42786    42850      +64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@w5688414 w5688414 mentioned this pull request Apr 29, 2024
Closed
wawltor
wawltor approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 3aa92ce into PaddlePaddle:develop Apr 30, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor approved these changes

@ZHUI ZHUI ZHUI left review comments

Assignees

@w5688414 w5688414

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@w5688414 @wawltor @ZHUI