[Models]Add pp for chatglmv2 #9043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PaddleNLP into add_pp_for_chatglmv2
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9043 +/- ##
===========================================
- Coverage 53.26% 53.21% -0.05%
===========================================
Files 652 654 +2
Lines 105615 105775 +160
===========================================
+ Hits 56254 56293 +39
- Misses 49361 49482 +121 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Sep 13, 2024
| @@ -185,7 +185,7 @@ def __init__(self, config: ChatGLMv2Config, empty_init=True): | |||
| if self.post_layer_norm: | |||
| LayerNormFunc = RMSNorm if config.rmsnorm else nn.LayerNorm | |||
| # Final layer norm before output. | |||
| self.final_layernorm = LayerNormFunc(config.hidden_size, epsilon=config.layernorm_epsilon) | |||
| self.final_layernorm = LayerNormFunc(config.hidden_size, epsilon=config.layernorm_epsilon, config=config) | |||
ZHUI
reviewed
Sep 13, 2024
| @@ -97,7 +150,7 @@ def apply_rotary_pos_emb(x: paddle.Tensor, rope_cache: paddle.Tensor) -> paddle. | |||
|
|
|||
|
|
|||
| class RMSNorm(nn.Layer): | |||
| def __init__(self, hidden_size, epsilon=None): | |||
| def __init__(self, hidden_size, config: ChatGLMv2Config, epsilon=None): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, hidden_size, config: ChatGLMv2Config, epsilon=None): | |
| def __init__(self, config: ChatGLMv2Config): | |
| hidden_size = config.hidden_size | |
| eps = config.eps | |
| @@ -185,7 +185,7 @@ def __init__(self, config: ChatGLMv2Config, empty_init=True): | |||
| if self.post_layer_norm: | |||
| LayerNormFunc = RMSNorm if config.rmsnorm else nn.LayerNorm | |||
| # Final layer norm before output. | |||
| self.final_layernorm = LayerNormFunc(config.hidden_size, epsilon=config.layernorm_epsilon) | |||
| self.final_layernorm = LayerNormFunc(config.hidden_size, epsilon=config.layernorm_epsilon, config=config) | |||
There was a problem hiding this comment.
if config.rmsnorm:
RMSNorm(config)
else:
nn.LayerNorm(xxx,xx)
ZHUI
reviewed
Sep 13, 2024
|
|
||
| # Recompute defaults to False and is controlled by Trainer | ||
| self.enable_recompute = False | ||
| self.config = config | ||
| self.fp32_residual_connection = config.fp32_residual_connection | ||
|
|
||
| LayerNormFunc = RMSNorm if config.rmsnorm else nn.LayerNorm |
There was a problem hiding this comment.
class LayerNorm(nn.LayerNorm):
def __init__(self, config):
self.config = config
super().__init__(config.hidde_size, xx)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
[Models]
Description
add pp for chatglmv2