Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PPSCI Doc No.1】ppsci.data.process.transform.CropData #687

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Dec 10, 2023

PR types

Others

PR changes

Docs

Describe

#686 No. 1

文档补全快速方案:

  1. 安装
  1. 找到要补全代码的文档
  2. 打开文心一言:
请帮我补全代码注释部分。注释需要包含几个部分:
1. 说明:用于说明代码的用途
2. 参数(Args):用于说明函数/类的参数信息
3. 返回(Returns):用于说明该函数/类的返回值
5. 样例(Examples):用于说明函数/类的使用方法
请补全缺失的信息,如果已有的描述不够完整,请补充的更为完整
需要补全的代码是{codes}
  1. 根据结果微调,你可以加一些额外的要求,例如
  • 当前的说明内容不完整,请补充的更多一些
  • 当前的样例不够完整,请给出一个能够直接调用的样例代码
  1. 验证
    你可以执行并验证代码、预览文档。

Copy link

paddle-bot bot commented Dec 10, 2023

Thanks for your contribution!

@luotao1 luotao1 changed the title 【API docs add】No.1 【PPSCI Doc No.1】ppsci.data.process.transform.CropData Dec 11, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 11, 2023
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这样改比较好

ppsci/data/process/transform/preprocess.py Outdated Show resolved Hide resolved
Co-authored-by: HydrogenSulfate <490868991@qq.com>
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,辛苦大佬

@HydrogenSulfate HydrogenSulfate merged commit 6a7e1a4 into PaddlePaddle:develop Dec 20, 2023
3 of 4 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* add discribe

* Apply suggestions from code review

* Update ppsci/data/process/transform/preprocess.py

Co-authored-by: HydrogenSulfate <490868991@qq.com>

---------

Co-authored-by: HydrogenSulfate <490868991@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants