Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bugs fix #851

Merged
merged 3 commits into from
Nov 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions frontend/packages/core/src/components/Audio.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const Container = styled.div`
cursor: pointer;
${transitionProps('color')}

&.volumn {
&.volume {
font-size: ${rem(20)};
${size(rem(20), rem(20))}
}
Expand Down Expand Up @@ -80,7 +80,7 @@ const Container = styled.div`
}
`;

const VolumnSlider = styled(Slider)`
const VolumeSlider = styled(Slider)`
margin: ${rem(15)} ${rem(18)};
width: ${rem(4)};
height: ${rem(100)};
Expand Down Expand Up @@ -170,7 +170,7 @@ const Audio: FunctionComponent<AudioProps & WithStyled> = ({
const [duration, setDuration] = useState('00:00');
const [decoding, setDecoding] = useState(false);
const [playing, setPlaying] = useState(false);
const [volumn, setVolumn] = useState(100);
const [volume, setVolume] = useState(100);
const [playAfterSeek, setPlayAfterSeek] = useState(false);

const play = useCallback(() => player.current?.play(), []);
Expand Down Expand Up @@ -199,7 +199,7 @@ const Audio: FunctionComponent<AudioProps & WithStyled> = ({
const toggleMute = useCallback(() => {
if (player.current) {
player.current.toggleMute();
setVolumn(player.current.volumn);
setVolume(player.current.volume);
}
}, []);

Expand Down Expand Up @@ -228,9 +228,9 @@ const Audio: FunctionComponent<AudioProps & WithStyled> = ({

useEffect(() => {
if (player.current) {
player.current.volumn = volumn;
player.current.volume = volume;
}
}, [volumn]);
}, [volume]);

useEffect(() => {
let p: AudioPlayer | null = null;
Expand Down Expand Up @@ -269,15 +269,15 @@ const Audio: FunctionComponent<AudioProps & WithStyled> = ({
};
}, [data, startTimer, stopTimer, onLoading, onLoad, audioContext]);

const volumnIcon = useMemo(() => {
if (volumn === 0) {
const volumeIcon = useMemo(() => {
if (volume === 0) {
return 'mute';
}
if (volumn <= 50) {
return 'volumn-low';
if (volume <= 50) {
return 'volume-low';
}
return 'volumn';
}, [volumn]);
return 'volume';
}, [volume]);

if (loading) {
return <SyncLoader color={primaryColor} size="15px" />;
Expand Down Expand Up @@ -313,18 +313,18 @@ const Audio: FunctionComponent<AudioProps & WithStyled> = ({
interactive
hideOnClick={false}
content={
<VolumnSlider
value={volumn}
<VolumeSlider
value={volume}
min={0}
max={100}
step={1}
onChange={setVolumn}
onChange={setVolume}
orientation="vertical"
/>
}
>
<a className="control volumn" onClick={toggleMute}>
<Icon type={volumnIcon} />
<a className="control volume" onClick={toggleMute}>
<Icon type={volumeIcon} />
</a>
</Tippy>
</Container>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ const ScalarChart: FunctionComponent<ScalarChartProps> = ({
const formatter = useCallback(
(params: EChartOption.Tooltip.Format | EChartOption.Tooltip.Format[]) => {
const series: Dataset[number] = Array.isArray(params) ? params[0].data : params.data;
const points = nearestPoint(smoothedDatasets ?? [], runs, series[1]).map((point, index) => ({
const idx = xAxisMap[xAxis];
const points = nearestPoint(smoothedDatasets ?? [], runs, idx, series[idx]).map((point, index) => ({
...point,
...datasetRanges?.[index]
}));
Expand All @@ -212,7 +213,7 @@ const ScalarChart: FunctionComponent<ScalarChartProps> = ({
<TooltipTable run={t('common:runs')} runs={sorted.map(i => i.run)} columns={columns} data={data} />
);
},
[smoothedDatasets, datasetRanges, runs, sortingMethod, maxStepLength, t, i18n]
[smoothedDatasets, datasetRanges, runs, sortingMethod, xAxis, maxStepLength, t, i18n]
);

const options = useMemo(
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/graph/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export type Property = {
name?: string;
value: string;
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/high-dimensional/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import type {Point} from './types';

export type {Dimension, Reduction, Point} from './types';
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/high-dimensional/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export type Dimension = '2d' | '3d';
export type Reduction = 'pca' | 'tsne';

Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/histogram/chart.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import type {EChartOption, VisualMap} from 'echarts';

import type {Modes} from './types';
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/histogram/data.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import type {HistogramData, OffsetData, OffsetDataItem, OverlayData, OverlayDataItem} from './types';

import {Modes} from './types';
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/histogram/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import {Modes} from './types';

export const modes = [Modes.Offset, Modes.Overlay] as const;
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/histogram/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export enum Modes {
Offset = 'offset',
Overlay = 'overlay'
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/pr-curve/chart.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export const options = {
legend: {
data: []
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/pr-curve/data.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export const nearestPoint = (data: number[][][], recall: number): number[][][] => {
return data.map(series => {
let delta = Number.POSITIVE_INFINITY;
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/pr-curve/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export type {PRCurveData, Run, StepInfo, Tag} from './types';
export {TimeType} from './types';
export * from './chart';
Expand Down
16 changes: 16 additions & 0 deletions frontend/packages/core/src/resource/pr-curve/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/**
* Copyright 2020 Baidu Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import {Run as BaseRun, Tag as BaseTag, TimeMode} from '~/types';

export {TimeMode as TimeType};
Expand Down
Loading