【Hackathon No.21】add RFC for SoftMarginLoss #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。 |
|
请先签署cla噢~ |
已经签署，辛苦CR |
yingyibiao
reviewed
Apr 29, 2022
Comment on lines
+162
to
+163
| paddle.nn.SoftMarginLoss(size_average=None, reduce=None, reduction='mean') -> Tensor | ||
| 该函数底层调用padde.nn.functional.soft_margin_loss |
There was a problem hiding this comment.
这里的size_average和reduce参数是否还有必要呢？
Comment on lines
+158
to
+159
| padde.nn.functional.soft_margin_loss(input Tensor[float64 or float32], target Tensor[float64 or float32],size_average [bool optional]默认为true,reduce [bool]作为参数，默认为true, reduction='mean', 'mean' 求平均,'sum'求和,'None', negative, Tensor[float64 or float32],维度为[batch_size,dim]) -> Tensor | ||
|
|
There was a problem hiding this comment.
input 和 target 的维度设置 [batch_size,dim] 是基于什么考虑呢？data_type设置为 float 是基于什么考虑呢？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.