[rfc] modify cummax / cummin API design #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Star125
changed the title
2 tasks
GGBond8488
reviewed
May 11, 2023
| @@ -300,9 +300,8 @@ gpu： | |||
| template <typename T, typename Context> | |||
| void CummaxKernel(const Context& dev_ctx, | |||
| const DenseTensor& x, | |||
| const Scalar& axis, | |||
| DataType dtype, | |||
| bool flatten, | |||
There was a problem hiding this comment.
这里为什么去掉了flatten呢？cummin同
There was a problem hiding this comment.
cumsum的flatten用于反向算子执行前调整形状，而cummax/cummin的反向不依赖flatten，所以就去掉了
There was a problem hiding this comment.
嗯，我看见你把flatten操作在python层做了，解决一下代码pr的 windows ci问题吧
luotao1
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此pr用于标识算子最新的设计，可能用于算子PR review，后续应该还有更改，暂时不用合入
相关Link：