Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.17】 为 Paddle 新增 pdist API #660

Merged
merged 14 commits into from
Oct 9, 2023
Merged

【Hackathon 5th No.17】 为 Paddle 新增 pdist API #660

merged 14 commits into from
Oct 9, 2023

Conversation

cocoshe
Copy link
Contributor

@cocoshe cocoshe commented Sep 26, 2023

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

GreatV
GreatV reviewed Sep 27, 2023
View reviewed changes
rfcs/20230926_api_design_for_pdist.md Outdated

## 命名与参数设计

API的设计为paddle.cdist(x, y, p=2.0)，其中 `x` 严格为 shape=[M, N] 的 Tensor，`p` 为p-范数对应的p值，输出为一行 `Mx(M-1)/2` 列的 Tensor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥变成了 cdist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥变成了 cdist

typo，sry已修正，辛苦review~

@Ligoml Ligoml mentioned this pull request Sep 27, 2023
Open
@cocoshe cocoshe changed the title 【Hackathon 5th No.17】 为 Paddle 新增 pdist API 【Hackathon 5th No.17】 为 Paddle 新增 pdist API 和 bitwise_right_shift 系列 API Sep 27, 2023
@cocoshe cocoshe changed the title 【Hackathon 5th No.17】 为 Paddle 新增 pdist API 和 bitwise_right_shift 系列 API 【Hackathon 5th No.17】 为 Paddle 新增 pdist API Sep 27, 2023
@cocoshe cocoshe mentioned this pull request Oct 3, 2023
Merged
zxcd
zxcd reviewed Oct 7, 2023
View reviewed changes
rfcs/APIs/20230926_api_design_for_pdist.md Outdated

## 3、意义

飞桨支持直接两两计算向量间的距离。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太通顺，建议修改一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

飞桨支持计算大小为(NxM)的矩阵中，N个向量两两之间的p-norm距离。

@cocoshe
Copy link
Contributor Author

cocoshe commented Oct 7, 2023

已做相应修改，不知道还有没有什么问题，辛苦review~

zxcd
zxcd approved these changes Oct 8, 2023
View reviewed changes
Copy link

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 28f88ab into PaddlePaddle:master Oct 9, 2023
1 check passed
yangguohao pushed a commit to yangguohao/community that referenced this pull request Oct 22, 2023
@cocoshe @yangguohao
【Hackathon 5th No.17】 为 Paddle 新增 pdist API (PaddlePaddle#660)
e196248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreatV GreatV GreatV left review comments

@luotao1 luotao1 luotao1 approved these changes

@zxcd zxcd zxcd approved these changes

Assignees

@luotao1 luotao1

@zxcd zxcd

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cocoshe @luotao1 @zxcd @GreatV