【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） #6878

Asthestarsfalll · 2024-09-18T06:12:35Z

【Hackathon 7th】开源贡献个人挑战赛 Paddle#68244

paddle-bot · 2024-09-18T06:12:43Z

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6878.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

zhwesky2010

麻烦根据文档模板规范https://github.com/PaddlePaddle/docs/blob/develop/docs/guides/model_convert/convert_from_pytorch/pytorch_api_mapping_format_cn.md ，一一核对并检查无误。

不符合文档规范，不予合入

...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool1d.md

...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool2d.md

...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool1d.md

...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool2d.md

.../model_convert/convert_from_pytorch/api_difference/nn/torch.nn.AdaptiveLogSoftmaxWithLoss.md

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md

...onvert/convert_from_pytorch/api_difference/nn/torch.nn.utils.parametrizations.weight_norm.md

docs/guides/model_convert/convert_from_pytorch/api_difference/optimizer/torch.optim.RAdam.md

CLAassistant · 2024-09-18T13:28:28Z

All committers have signed the CLA.

Asthestarsfalll

已按照文档要求更新，劳烦再审核下

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md

zhwesky2010 · 2024-09-19T08:43:46Z

@Asthestarsfalll 映射文档有问题，未通过CI不予合入：

1394 mapping documents found in api_difference.
2024-09-18 21:37:29 16 mapping documents found in api_difference_third_party/transformers.
2024-09-18 21:37:29 7 mapping documents found in api_difference_third_party/fairscale.
2024-09-18 21:37:29 4 mapping documents found in api_difference_third_party/flash_attn.
2024-09-18 21:37:29 Traceback (most recent call last):
2024-09-18 21:37:29   File "/FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/apply_references.py", line 319, in <module>
2024-09-18 21:37:29     metas = discover_all_metas(cfp_basedir)
2024-09-18 21:37:29   File "/FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/validate_mapping_files.py", line 635, in discover_all_metas
2024-09-18 21:37:29     metas.append(get_meta_from_diff_file(f, s, d, src_argmap_title=sh))
2024-09-18 21:37:29   File "/FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/validate_mapping_files.py", line 208, in get_meta_from_diff_file
2024-09-18 21:37:29     raise ValueError(
2024-09-18 21:37:29 ValueError: Unexpected mapping type: Paddle ???????????? in /FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/../api_difference/functional/torch.nn.functional.lp_pool2d.md
2024-09-18 21:37:29 Error: API mapping generate script failed, please check changes in /FluidDoc/docs/guides/model_convert/convert_from_pytorch

zhwesky2010 · 2024-09-23T07:24:53Z

...t_from_pytorch/api_difference/functional/torch.nn.functional.scaled_dot_product_attention.md

+| dropout_p | dropout_p    | `dropout` 的比例, 默认值为 0.00 即不进行正则化。                                                                |
+| is_causal | is_causal    | 是否启用因果关系, 默认值为 `False` 即不启用。                                                                   |
+| scale     | -            | 在softmax之前应用的缩放因子。默认与 Paddle 行为一致。Paddle 无此参数，暂无转写方式。                            |
+| -         | training     | 是否处于训练阶段, 默认值为 `True` 即处于训练阶段。Pytorch 无此参数，Paddle 需要按照是否处于训练阶段设置。       |


这个取决于torch如何设置，不看paddle怎么设置。

如果torch的行为等同于training=True，那就写paddle保持默认即可。如果torch的行为等同于training=False，那可能这两个API无法直接映射，需要看一下有没有更好的组合方式。

zhwesky2010 · 2024-09-23T07:27:04Z

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.CircularPad3d.md

+### [paddle.nn.Pad3D](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/nn/Pad3D_cn.html#pad3d)
+
+```python
+paddle.nn.Pad3D(padding, mode='constant', value=0.0, data_format='NCDHW', name=None)


mode应该是'circular'吧

zhwesky2010 · 2024-09-23T07:27:21Z

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.CircularPad3d.md

+| PyTorch       | PaddlePaddle | 备注                                                                         |
+| ------------- | ------------ | ---------------------------------------------------------------------------- |
+| padding       | padding      | 填充大小。                                                                   |
+| -             | mode         | `padding` 的四种模式。PyTorch 无此参数，Paddle 应设置为 `constant`。         |


Paddle应设置为'circular'吧

zhwesky2010 · 2024-09-23T07:29:39Z

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md

+
+# Paddle 写法
+module = paddle.nn.Softmax(axis=1)
+module(-input)


写成 -1 * input 吧，再加个注释强调一下

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组）

1a0d42a

luotao1 mentioned this pull request Sep 18, 2024

【Hackathon 7th】开源贡献个人挑战赛 PaddlePaddle/Paddle#68244

Open

luotao1 added the PaddlePaddle Hackathon 飞桨黑客松活动issue与PR label Sep 18, 2024

luotao1 assigned luotao1, zhwesky2010 and sunzhongkai588 Sep 18, 2024

zhwesky2010 mentioned this pull request Sep 18, 2024

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） PaddlePaddle/PaConvert#477

Open

zhwesky2010 reviewed Sep 18, 2024

View reviewed changes

update due to mapping format

8a33e51

Asthestarsfalll added 2 commits September 18, 2024 21:30

update

8e11162

update

fdb5053

Asthestarsfalll commented Sep 18, 2024

View reviewed changes

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md Show resolved Hide resolved

paddle-bot bot added the contributor label Sep 18, 2024

Asthestarsfalll added 5 commits September 19, 2024 19:00

Fix mapping of lp_pool2d

dc9a155

Fix mapping

4d4d3b2

fix mapping of threshold_

d824771

fix

8c3f62e

fix

816f3e0

zhwesky2010 reviewed Sep 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） #6878

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） #6878

Asthestarsfalll commented Sep 18, 2024 •

edited

Loading

paddle-bot bot commented Sep 18, 2024

zhwesky2010 left a comment •

edited

Loading

CLAassistant commented Sep 18, 2024 •

edited

Loading

Asthestarsfalll left a comment

zhwesky2010 commented Sep 19, 2024

zhwesky2010 Sep 23, 2024 •

edited

Loading

zhwesky2010 Sep 23, 2024

zhwesky2010 Sep 23, 2024

zhwesky2010 Sep 23, 2024

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） #6878

Are you sure you want to change the base?

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） #6878

Conversation

Asthestarsfalll commented Sep 18, 2024 • edited Loading

paddle-bot bot commented Sep 18, 2024

zhwesky2010 left a comment • edited Loading

Choose a reason for hiding this comment

CLAassistant commented Sep 18, 2024 • edited Loading

Asthestarsfalll left a comment

Choose a reason for hiding this comment

zhwesky2010 commented Sep 19, 2024

zhwesky2010 Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

zhwesky2010 Sep 23, 2024

Choose a reason for hiding this comment

zhwesky2010 Sep 23, 2024

Choose a reason for hiding this comment

zhwesky2010 Sep 23, 2024

Choose a reason for hiding this comment

Asthestarsfalll commented Sep 18, 2024 •

edited

Loading

zhwesky2010 left a comment •

edited

Loading

CLAassistant commented Sep 18, 2024 •

edited

Loading

zhwesky2010 Sep 23, 2024 •

edited

Loading