Skip to content

Commit

Permalink
Add warning when HOST environment variable is set (facebook#3730)
Browse files Browse the repository at this point in the history
* Add warning when HOST environment variable is set (facebook#3719)

* Improve HOST environment variable warning message

* Adjust text and message

Closes facebook#3719
  • Loading branch information
iansu authored and Pavel Zhytko committed Jul 10, 2018
1 parent 337211a commit 21a3d0c
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions packages/react-scripts/scripts/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ if (!checkRequiredFiles([paths.appHtml, paths.appIndexJs])) {
const DEFAULT_PORT = parseInt(process.env.PORT, 10) || 3000;
const HOST = process.env.HOST || '0.0.0.0';

if (process.env.HOST) {
console.log(
chalk.cyan(
`Attempting to bind to HOST environment variable: ${chalk.yellow(
chalk.bold(process.env.HOST)
)}`
)
);
console.log(
`If this was unintentional, check that you haven't mistakenly set it in your shell.`
);
console.log(`Learn more here: ${chalk.yellow('http://bit.ly/2mwWSwH')}`);
console.log();
}

// We attempt to use the default port but if it is busy, we offer the user to
// run on a different port. `choosePort()` Promise resolves to the next free port.
choosePort(HOST, DEFAULT_PORT)
Expand Down

0 comments on commit 21a3d0c

Please sign in to comment.