Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Spring 5 WebFlux reactive in Spring Boot 2 #333

Closed
hectorlf opened this issue Apr 26, 2018 · 5 comments
Closed

Support for Spring 5 WebFlux reactive in Spring Boot 2 #333

hectorlf opened this issue Apr 26, 2018 · 5 comments
Labels
pull request welcome
Milestone
3.1.2

Comments

@hectorlf
Copy link
Member

With the new focus on reactive from Spring 5 and Spring Boot 2, Pebble is now at a disatvantage. Any newcomer to Spring that wants to try the reactive support will be forced to use Freemarker or Thymeleaf.
@hectorlf hectorlf mentioned this issue Apr 26, 2018
Open
@mikaelhg
Copy link

Suggestion: change the issue title to "Support for Spring 5 WebFlux reactive in Spring Boot 2 autoconfiguration".

@hectorlf
Copy link
Member Author

We could very well close this issue, as it will probably never be implemented.

@ThanosFisherman
Copy link

Why not though? This is a vital feature for those who use non blocking web frameworks.

@ebussieres ebussieres reopened this Nov 30, 2019
@ebussieres
Copy link
Member

Any help would be appreciated on this one

@ebussieres ebussieres added this to the 3.1.2 milestone Dec 3, 2019
@ebussieres ebussieres changed the title Pebble needs to support reactive programming Support for Spring 5 WebFlux reactive in Spring Boot 2 Dec 3, 2019
ebussieres added a commit that referenced this issue Dec 3, 2019
@ebussieres
Add basic support for Spring 5 WebFlux reactive in Spring Boot 2 (#333)
4773093
ebussieres added a commit that referenced this issue Dec 3, 2019
@ebussieres
Add basic support for Spring 5 WebFlux reactive in Spring Boot 2 (#333)
cb99a41
ebussieres added a commit that referenced this issue Dec 3, 2019
@ebussieres
Add basic support for Spring 5 WebFlux reactive in Spring Boot 2 (#333)…
e620b02 
… (#489)
@ebussieres
Copy link
Member

I've just added basic support for Spring 5 WebFlux reactive in Spring Boot 2. It's gonna be available in next release

@dependabot-preview dependabot-preview bot mentioned this issue Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pull request welcome
Projects
None yet
Milestone
3.1.2
Development

No branches or pull requests
4 participants
@mikaelhg @hectorlf @ThanosFisherman @ebussieres