3.1.4 or 3.1.3 breaks custom operators

[Big-Whoop]

I just updated pebble from 3.1.2 to 3.1.4 and found that my custom operators no longer work. The BinaryOperator Interface has changed while a patch or minor version normally shouldn't introduce breaking changes on public interfaces.

I also found that the documentation hasn't been updated.

I tried to implement the new interface but now all my operators run into a stack overflow with no obvious reason. I Might be doing something wrong or I discovered a bug.

Is it possible to update the doumentation so I can verify if my implementation is correct?

[ebussieres]

Here's the pull request that has changed the interface

https://github.com/PebbleTemplates/pebble/pull/499/files

[Big-Whoop]

Hi, thank you, I found my error. I interpreted the "getInstance()" method so that I should return a singleton instance of the Expression instead of creating a new instance each time. If I do the latter it works as expected.

Maybe createInstance() would be a better and less confusing name for this method because getInstance() is a well known method name for a singleton pattern.

[ebussieres]

I've just adjusted the doc. In another major release, I'll rename the getInstance method, so I'll keep it open

[ebussieres]

Gonna be available in next release