Fix issue of embed tag changing cached templates #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue of embed tag changing cached templates and breaking includes using the same-named template from the cache.
For example, let's say
templateA.pebembedstemplateX.peb, whiletemplateB.pebjust includes it. If template caching is enabled, both the embed and include tag will use the same cachedPebbleTemplateImplobject. But for the embed tag to work, it needed to change some of the data in that template, so that later on, when it's just included later, the modified template is being included.By making a shallow copy of the cached template, the embed tag can make the changes it needs to without affecting what's already in the cache.