Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to job.sh model2netcdf line #3075

Merged
merged 14 commits into from
Jan 7, 2023
Merged

Fix to job.sh model2netcdf line #3075

merged 14 commits into from
Jan 7, 2023

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Dec 12, 2022

Description

With large numbers of PFTs the model2netcdf.ED2() line in job.sh would get cut off. This is because deparse() has a default line width cutoff and would then split the output into multiple lines. I've replaced it with deparse1() which always produces a character vector of length 1.

Motivation and Context

The model2netcdf.ed2() step was failing for runs with more than a few PFTs

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Aariq Aariq marked this pull request as ready for review December 12, 2022 21:25
Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just few minor questions about bumping version and comments

models/ed/inst/template.job Outdated Show resolved Hide resolved
models/ed/DESCRIPTION Outdated Show resolved Hide resolved
@Aariq Aariq requested a review from dlebauer December 21, 2022 17:15
models/ed/NEWS.md Outdated Show resolved Hide resolved
@dlebauer dlebauer merged commit d173a07 into develop Jan 7, 2023
@dlebauer dlebauer deleted the job-sh branch January 7, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants