Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for field not method complaint in strum_macro's metadata.rs #164

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

hlmtre
Copy link
Contributor

@hlmtre hlmtre commented Jun 1, 2021

see

@Peternator7
Copy link
Owner

Interesting, do you know what syn version you're using? value() was added to syn around 1.0.61 Docs Commit

I'm fine accepting this since it appears it will improve compatibility, but there might be an opportunity for another plugin to use a newer version of syn here as well.

@hlmtre
Copy link
Contributor Author

hlmtre commented Jun 1, 2021

cargo tree and inverted, selecting for syn. it appears it's being pulled 'first' for serde_derive, which, even on the most recent master commit 20 days ago, depends tantalizingly closely on 1.0.60.

i ain't gonna be the guy that suggests a project as big and scary as serde update their syn dependency 😰

@Peternator7
Copy link
Owner

How disappointing! This is an easy enough workaround though and lower stakes than updating serde-derive as you said, so I'll go ahead and merge this change in.

@Peternator7 Peternator7 merged commit dcd8df1 into Peternator7:master Jun 2, 2021
Peternator7 pushed a commit that referenced this pull request Jun 2, 2021
@hlmtre hlmtre deleted the field-fix branch June 2, 2021 05:49
Peternator7 added a commit that referenced this pull request Jun 2, 2021
Co-authored-by: Peter Glotfelty <peter@glotfelty.us>
@Peternator7
Copy link
Owner

Version 0.21.1 is out. https://crates.io/crates/strum_macros

@hlmtre
Copy link
Contributor Author

hlmtre commented Jun 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants