Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TryFrom to FromRepr #217

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Add TryFrom to FromRepr #217

merged 2 commits into from
Apr 30, 2022

Conversation

danog
Copy link
Contributor

@danog danog commented Apr 1, 2022

Similar to #186, automatically implements TryFrom based on the discriminant type.

@Peternator7
Copy link
Owner

Hello @danog, Thanks for the PR! I'm onboard with the general idea. The test failures in 1.32 look legitimate so if you can fix those, we can merge this.

@danog
Copy link
Contributor Author

danog commented Apr 19, 2022

This should do the trick! :D

@Peternator7 Peternator7 merged commit ac757fa into Peternator7:master Apr 30, 2022
Peternator7 added a commit that referenced this pull request Jun 19, 2022
Peternator7 added a commit that referenced this pull request Jun 25, 2022
Peternator7 pushed a commit that referenced this pull request Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants