Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider avoiding the use of a pre-sized builder for the FilteredCollection and FilteredMultimapValues in Maps#uniqueIndex #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Consider avoiding the use of a pre-sized builder for the FilteredCollection and FilteredMultimapValues in Maps#uniqueIndex #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ec4e9
Consider avoiding the use of a pre-sized builder for the `FilteredCol…
oksana-evs Jul 14, 2023
6c47dd6
Apply the change to `android/guava/src/com/google/common/collect/Maps…
oksana-evs Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/guava/src/com/google/common/collect/Maps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Predicate;
import com.google.common.base.Predicates;
import com.google.common.collect.Collections2.FilteredCollection;
import com.google.common.collect.MapDifference.ValueDifference;
import com.google.common.primitives.Ints;
import com.google.errorprone.annotations.CanIgnoreReturnValue;
Expand Down Expand Up @@ -1247,7 +1248,8 @@ public static <K, V> ImmutableMap<K, V> toMap(
@CanIgnoreReturnValue
public static <K, V> ImmutableMap<K, V> uniqueIndex(
Iterable<V> values, Function<? super V, K> keyFunction) {
if (values instanceof Collection) {
if (values instanceof Collection
&& !(values instanceof FilteredCollection || values instanceof FilteredMultimapValues)) {
return uniqueIndex(
values.iterator(),
keyFunction,
Expand Down
4 changes: 3 additions & 1 deletion guava/src/com/google/common/collect/Maps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Predicate;
import com.google.common.base.Predicates;
import com.google.common.collect.Collections2.FilteredCollection;
import com.google.common.collect.MapDifference.ValueDifference;
import com.google.common.primitives.Ints;
import com.google.errorprone.annotations.CanIgnoreReturnValue;
Expand Down Expand Up @@ -1325,7 +1326,8 @@ public static <K, V> ImmutableMap<K, V> toMap(
@CanIgnoreReturnValue
public static <K, V> ImmutableMap<K, V> uniqueIndex(
Iterable<V> values, Function<? super V, K> keyFunction) {
if (values instanceof Collection) {
if (values instanceof Collection
&& !(values instanceof FilteredCollection || values instanceof FilteredMultimapValues)) {
return uniqueIndex(
values.iterator(),
keyFunction,
Expand Down