Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occlusion culling breaks when the camera is exactly on a chunk border #514

Closed
IntegratedQuantum opened this issue Jun 22, 2024 · 0 comments
Closed

Occlusion culling breaks when the camera is exactly on a chunk border #514

IntegratedQuantum opened this issue Jun 22, 2024 · 0 comments
Labels
bug something isn't working in the intended way graphics
Milestone
Long-Term Goals

Comments

@IntegratedQuantum
Copy link
Member

Screenshot at 2024-06-22 15-23-07
Best solution would probably be to finally switch to #174
@IntegratedQuantum IntegratedQuantum added bug something isn't working in the intended way graphics labels Jun 22, 2024
@IntegratedQuantum IntegratedQuantum added this to the Short-Term Goals milestone Jun 22, 2024
IntegratedQuantum added a commit that referenced this issue Jun 24, 2024
@IntegratedQuantum
Increase eye height to 1.7
85130a9 
Makes #514 less severe.
AlexDavies8 pushed a commit to AlexDavies8/Cubyz that referenced this issue Sep 19, 2024
@IntegratedQuantum @AlexDavies8
Make flying through caves fun again (removes CPU-side occlusion culling)
fd65785 
This is not quite the performance improvement I had planned.
On the GPU-side the raster occlusion culling step got more expensive, since there now are more chunks checked on average.
On the CPU-side the cost of traversing all the occluded chunks is roughly equal to the cost of the previous occlusion culling heuristic.
On the bright side the cost is now constant, whereas previously looking into the sky was twice as expensive.

fixes PixelGuys#526
fixes PixelGuys#514
fixes PixelGuys#259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working in the intended way graphics
Projects
None yet
Milestone
Long-Term Goals
Development

No branches or pull requests
1 participant
@IntegratedQuantum