Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PP-51 default callback URI for each domain PPT-728 #108

Merged
merged 3 commits into from
Jul 19, 2023
Merged

feat: PP-51 default callback URI for each domain PPT-728 #108

merged 3 commits into from
Jul 19, 2023

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Jul 18, 2023

No description provided.

@naqvis naqvis requested a review from stakach July 18, 2023 14:45
@github-actions github-actions bot added the type: enhancement new feature or request label Jul 18, 2023
stakach
stakach requested changes Jul 18, 2023
View reviewed changes
lib/omniauth/strategies/generic_oauth.rb Outdated Show resolved Hide resolved
@stakach
Copy link
Member

stakach commented Jul 18, 2023

Also I've inadvertently re-introduced protocolbuffers/protobuf#11968 as I didn't realise it was only fixed in a release candidate. (3.24.0.rc2)
Could you please revert protobuf to version 3.22.0

@jeremyw24 jeremyw24 changed the title feat: PP-51 default callback URI for each domain feat: PP-51 default callback URI for each domain PPT-728 Jul 18, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Jul 18, 2023
naqvis and others added 2 commits July 19, 2023 12:53
@naqvis
Copy link
Contributor Author

naqvis commented Jul 19, 2023

I reverted google-protobuf to version 3.21.12 as this was working fine on both amd/arm architecture

stakach
stakach approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach merged commit 581256e into master Jul 19, 2023
2 of 4 checks passed
@stakach stakach deleted the PP-51-default-callback-uri branch July 19, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach approved these changes

Assignees
No one assigned
Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naqvis @stakach