Adds a check for when CreateFileMappingA fails #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreateFileMappingA returns a NULL handle when it fails for example due to insufficient disk space which leads to a crash when memcpy tries to access the map.
io/include/pcl/io/impl/pcd_io.hpp
Outdated
| @@ -197,6 +197,11 @@ pcl::PCDWriter::writeBinary (const std::string &file_name, | |||
| // Prepare the map | |||
| #if _WIN32 | |||
| HANDLE fm = CreateFileMappingA (h_native_file, NULL, PAGE_READWRITE, 0, (DWORD) (data_idx + data_size), NULL); | |||
| if (fm == NULL) | |||
| { | |||
| throw pcl::IOException("[pcl::PCDWriter::writeBinary] Error during write ()!"); | |||
There was a problem hiding this comment.
Modify the error message to indicate that there was an error during memory map creation.
|
👍 Thanks. |
SergioRAgostinho
added
needs: author reply
SergioRAgostinho
removed
the
needs: author reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateFileMappingA returns a NULL handle when it fails for example due to insufficient disk space which leads to a crash when memcpy tries to access the map.