Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark imported libraries as GLOBAL in PCLConfig #2435

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Sep 11, 2018

Fixes #2431.

Following up the discussion in #2431 I demoted exported targets to be local. The component "has been found already" test is reverted back to check PCL_xxx_FOUND variable. As a result:

  • PCL found in sibling subdirectories are not visible to each other
  • PCL found in parent directory is visible in subdirectories
  • it's possible to find PCL several times in the same scope

A little more explanation for the last point. Suppose the root CMakeLists finds only few PCL components:

find_package(PCL REQUIRED COMPONENTS common features)

After that it's okay if in a subdirectory another search is performed with more components:

find_package(PCL REQUIRED COMPONENTS common visualization tracking)

@jasjuang Please give this an extensive testing :)

@taketwo taketwo added needs: testing Specify why not closed/merged yet module: cmake labels Sep 11, 2018
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.9.0 milestone Sep 11, 2018
@jasjuang
Copy link
Contributor

@taketwo I tested this with various different use cases of mine and it's all working. Please merge!

@taketwo taketwo removed the needs: testing Specify why not closed/merged yet label Sep 12, 2018
@taketwo taketwo merged commit 81aa826 into PointCloudLibrary:master Sep 12, 2018
@taketwo taketwo deleted the fix-2431 branch March 9, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants