Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring typos' corrections. #2449

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Sep 18, 2018

Found via codespell -q 3 -I ../pcl-word-whitelist.txt --skip="./surface/include/pcl/surface/3rdparty,./surface/src/3rdparty,./recognition/include/pcl/recognition/3rdparty where whitelist consists of:

ang
childs
currect
currenty
everytime
iff
indeces
isnt
ith
lod
metre
metres
mitre
nd
normaly
opps
ot
resizeable
te
vertexes
uint

Found via `codespell -q 3 -I ../pcl-word-whitelist.txt --skip="./surface/include/pcl/surface/3rdparty,./surface/src/3rdparty,./recognition/include/pcl/recognition/3rdparty` where whitelist consists of:  
```
ang
childs
currect
currenty
everytime
iff
indeces
isnt
ith
lod
metre
metres
mitre
nd
normaly
opps
ot
resizeable
te
vertexes
uint
```
@SergioRAgostinho SergioRAgostinho changed the title Misc. typos Docstring typos' corrections. Sep 18, 2018
@SergioRAgostinho
Copy link
Member

Before merging, I was curious about some words which were whitelisted. Why exactly are they being whitelisted? Namely:

  • ang -> angle?
  • childs -> children
  • currect -> correct
  • currenty -> currently
  • everytime -> every time
  • indeces -> indices
  • isnt -> isn't
  • ith -> ?
  • lod -> level of detail?
  • mitre -> ?
  • nd -> ?
  • normaly -> normally
  • opps -> oops?
  • ot -> to?
  • te -> ?

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 18, 2018

Most are variables or parts of functions aka false positives.
normalY, currentY etc...
Feel free to disable them and run codespell to see the context.

@SergioRAgostinho SergioRAgostinho merged commit a63431b into PointCloudLibrary:master Sep 19, 2018
@luzpaz luzpaz deleted the misc-typos branch September 19, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants