Algorithm Result object complete rewrite, Add betweeen centrality, Add Zaks Karate Club

[Haaroon]

What changes were proposed in this pull request?

A complete rewrite of thr algorithm object,

• now allows users to get based on vertex ref, name etc.
• adds betweeness centrality algorithm
• adds karate club graph to built in graph gens
• added many missing functions to python and into the macros
• fixed all the associated algorithms and all their tests in both rust and python
• added new tests
• i hate macros ❤️
• Add betweeen centrality
• Add Zaks Karate Club
• returns vertexviews in the algo result instead when collected or queried
• added extra cmp checks in vertex+vertexview, added debug+fmt prints to vertexview
• added very very basic graph hashing

may not come with memory efficiency ™

Why are the changes needed?

it was becoming very messy

Does this PR introduce any user-facing change? If yes is this documented?

yes all methods should have docs

How was this patch tested?

python and rust tests

Issues

resolves #1129

Are there any further changes required?

i hope not

[codecov]

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (9df4985) 57.58% compared to head (44918c8) 58.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   57.58%   58.01%   +0.42%     
==========================================
  Files         186      188       +2     
  Lines       20011    20362     +351     
==========================================
+ Hits        11523    11812     +289     
- Misses       8488     8550      +62     

Files	Coverage Δ
python/src/lib.rs	4.76% <ø> (ø)
raphtory/src/algorithms/centrality/betweenness.rs	100.00% <100.00%> (ø)
...ory/src/algorithms/centrality/degree_centrality.rs	97.36% <100.00%> (+0.07%)	⬆️
raphtory/src/algorithms/centrality/hits.rs	100.00% <100.00%> (ø)
raphtory/src/algorithms/centrality/pagerank.rs	99.03% <100.00%> (-0.01%)	⬇️
...rithms/community_detection/connected_components.rs	99.41% <100.00%> (+0.02%)	⬆️
raphtory/src/algorithms/metrics/balance.rs	100.00% <100.00%> (ø)
raphtory/src/algorithms/metrics/reciprocity.rs	98.76% <100.00%> (+0.01%)	⬆️
...lgorithms/motifs/three_node_local_single_thread.rs	98.74% <100.00%> (+0.04%)	⬆️
...ry/src/algorithms/pathing/temporal_reachability.rs	93.82% <100.00%> (+0.18%)	⬆️
... and 16 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miratepuffin]

We need to go through some of these return types and extra for loops we have added as I think they are adding quite a bit of extra work. Can pair on this on monday.

[miratepuffin]

Loolks clean AF!
Couple of small suggestions for fixes + missing docs.
When we return via get_all can we add some small tests to check that the vertex has the correct views applied to it - i.e. if I run an algorithm on a windowed graph or a layered graph - when I get the result out it should also be windowed+layered.
Need to do benchmarking as discussed.

[Haaroon]

Loolks clean AF! Couple of small suggestions for fixes + missing docs. When we return via get_all can we add some small tests to check that the vertex has the correct views applied to it - i.e. if I run an algorithm on a windowed graph or a layered graph - when I get the result out it should also be windowed+layered. Need to do benchmarking as discussed.

added tests

[Haaroon]

FYI I was looking into our layered graphs, the layered graph do a layer on an edge_filter not a vertex filter. its assumed that vertices live on all layers, but their edges can be layered. Thus when running algorithms on a specific layer, you will get a result that contains all vertexes, as they exist in all layers but may not have an edge on that layer.