Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify AlgoResult.get to accept Strings in rust #1341

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

Haaroon
Copy link
Contributor

@Haaroon Haaroon commented Oct 19, 2023

What changes were proposed in this pull request?

Modify AlgoResult.get to accept Strings in rust

Why are the changes needed?

made code ugly

Does this PR introduce any user-facing change? If yes is this documented?

Yes, new tests

How was this patch tested?

tests

Issues

None

Are there any further changes required?

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b4eef2e) 58.01% compared to head (c9bc464) 58.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1341   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         188      188           
  Lines       20362    20360    -2     
=======================================
- Hits        11812    11811    -1     
+ Misses       8550     8549    -1     
Files Coverage Δ
raphtory/src/algorithms/algorithm_result.rs 94.24% <100.00%> (ø)
raphtory/src/algorithms/centrality/pagerank.rs 99.03% <100.00%> (ø)
raphtory/src/algorithms/metrics/reciprocity.rs 98.76% <100.00%> (ø)
...lgorithms/motifs/three_node_local_single_thread.rs 98.73% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Haaroon Haaroon merged commit 11e103d into master Oct 19, 2023
13 checks passed
@Haaroon Haaroon deleted the feature/algo_res_get_from_name branch October 19, 2023 14:27
fabianmurariu pushed a commit that referenced this pull request May 21, 2024
* modify get so you dont need the into

* remove old get fn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants